Fix the crash during recording #36569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses the following issue: Invalid read in audio demo #34494 Protect recording_data with a mutex to prevent racing. Tested with my crashing project on 3.2 branch for 5 minutes. No crashes.
|
Symbolic PR number 69 for the whole year. |
|
I don't think this is the right solution, but the original call creates a buffer in the audio thread.. |
|
@fire I am not sure I understand you. Do you suggest to create the buffer in the audio thread? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses the following issue: Invalid read in audio demo #34494
Protect recording_data with a mutex to prevent racing.
Tested with my crashing project on 3.2 branch for 5 minutes. No crashes.