Remove redundant thread sync counter draw_pending #35758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Serves the same purpose as #35759. I prefer this one. Correctness depends on my understanding of what CommandQueueMT does. |
|
Since VisualServer was replaced with RenderingServer in the |
The functions that used it already use a threadsafe FIFO queue to communicate between threads and a sync to have the main thread wait for the render thread. Fixes godotengine#35718
zmanuel
force-pushed
the
eliminate-draw-pending
branch
from
151eb41
to
fc73334
Compare
|
I updated this PR to current master, including system rename and multithreading architecture change (easy because it's just removing a thing and its use). If you really want this in 3.x as well, I prepared #47232. |
reduz
approved these changes
Jun 22, 2022
|
Sorry it took a while to review, but this seems correct! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions that used it already use a threadsafe FIFO queue
to communicate between threads and a sync to have the main thread
wait for the render thread.
Fixes #35718