Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the editor export template downloader #35568

Closed

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 26, 2020

  • Begin downloading as soon as the list of mirrors is fetched if only one mirror is available.
  • Only show the help text if there's more than one mirror available.
  • Only show the progress bar once the download has started.
  • Hide the list of mirrors and the help text once the download has started.
  • Make the window slightly shorter due to the low number of mirrors available.

PS: To test this locally, you need to change version.py's status line to rc3 then recompile.

- Begin downloading as soon as the list of mirrors is fetched
  if only one mirror is available.
- Only show the help text if there's more than one mirror available.
- Only show the progress bar once the download has started.
- Hide the list of mirrors and the help text once the download
  has started.
- Make the window slightly shorter due to the low number of mirrors
  available.
@YuriSizov
Copy link
Contributor

There are a couple of unresolved issues here still.

  1. If there are no sources, the UI just ends up in a weird state. An error is shown in a third (!!!) popup and then, when you close it, the second one remains with a fictitious progress:

image

  1. You can close the second popup as the templates download, but it keeps downloading. Attempts to bring that popup back result in a flash of progress and then an error that the archive couldn't be fetched. However, it still keeps downloading, and in flashes you can see it progressing, and eventually the UI properly updates with the installed version as it finishes.

image

  1. In the old version you couldn't Shift-Click to open the mirror in the browser after you start downloading, despite the link still showing the pointing finger cursor. In the new version you can't open the link in the browser at all if there is only one mirror. If this is a desired feature, then the URL needs to be displayed still somewhere, and the Shift-Click as it downloads needs to be fixed.

I'm not entirely sure why we need 2 popups here. We can make do with a single one and a better representation of installed versions and mirrors with a tree control.

@Calinou
Copy link
Member Author

Calinou commented May 15, 2021

In the old version you couldn't Shift-Click to open the mirror in the browser after you start downloading, despite the link still showing the pointing finger cursor. In the new version you can't open the link in the browser at all if there is only one mirror. If this is a desired feature, then the URL needs to be displayed still somewhere, and the Shift-Click as it downloads needs to be fixed.

The Shift-clicking part was mainly added for people having issues with slow downloads due to the low HTTPClient buffer size, but this is now solved since 3.3. It could be removed eventually.

@YuriSizov
Copy link
Contributor

YuriSizov commented May 16, 2021

Here's a little mockup of how this unified window may look:

2021-05-16_03-44-50.mp4
  1. Current version at the top, shows either the missing status, or the path to the downloaded templates. Progress is also displayed there, inline. While the progress is active Close button at the bottom shows a warning before closing. Closing the window should abort the download.
  2. Download button next to the current version automatically refreshes the sources and then uses the first one to download the templates. At the same time the list can be manually refreshed and the user can click on the Download button next to a particular source they want. We can also refresh the list of sources automatically when the popup opens if the current version is missing.
  3. We keep the button to open the source in the browser, can still be helpful for people behind some corporate proxy settings or something like that.
  4. Both current version and the list of all installed versions have a way to open the folder in the filesystem to access the files if needs be.
  5. All warnings, errors, confirmations are shown as a second level popup, as usual.

Sorry for a weird look in the video, I made it as a project, not as an editor change.

Edit: I also forgot the install from file button, but it should be easy to find a place for it.

@YuriSizov
Copy link
Contributor

I've opened #48902 to replace this one.

@Calinou
Copy link
Member Author

Calinou commented May 20, 2021

Closing, since this is superseded by #48902.

@Calinou Calinou closed this May 20, 2021
@Calinou Calinou added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants