-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the editor export template downloader #35568
Improve the editor export template downloader #35568
Conversation
- Begin downloading as soon as the list of mirrors is fetched if only one mirror is available. - Only show the help text if there's more than one mirror available. - Only show the progress bar once the download has started. - Hide the list of mirrors and the help text once the download has started. - Make the window slightly shorter due to the low number of mirrors available.
b977cc6
to
aeb8725
Compare
There are a couple of unresolved issues here still.
I'm not entirely sure why we need 2 popups here. We can make do with a single one and a better representation of installed versions and mirrors with a tree control. |
The Shift-clicking part was mainly added for people having issues with slow downloads due to the low HTTPClient buffer size, but this is now solved since 3.3. It could be removed eventually. |
Here's a little mockup of how this unified window may look: 2021-05-16_03-44-50.mp4
Sorry for a weird look in the video, I made it as a project, not as an editor change. Edit: I also forgot the install from file button, but it should be easy to find a place for it. |
I've opened #48902 to replace this one. |
Closing, since this is superseded by #48902. |
PS: To test this locally, you need to change
version.py
'sstatus
line torc3
then recompile.