Cyclic BlendSpaces [1D/2D] for Animation #34179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstaik
changed the title
marstaik
force-pushed
the
cyclic_blend
branch
from
20d4d30
to
c30eb28
Compare
|
Updated for current master branch |
|
Updated for 4.0 |
marstaik
force-pushed
the
cyclic_blend
branch
3 times, most recently
from
58f91b3
to
cf8de21
Compare
|
Probality not working with |
|
@SuperDIMMaX do you have a sample project I can check? |
|
|
@marstaik Are you ok with me taking this over? You can keep the pr open and I can modify your branch. |
Yeah, that's fine. :) |
This was referenced Jun 26, 2022
|
@TokageItLab Is this still valid? |
|
Closing based on above comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Depends on #34134, as the blends are even more broken without it.
This PR aims to do some bugfixing for blendspaces as well as introduce the concept of Cyclic BlendSpaces.
There was some previous discussion of this here: #23414
Coming from other game engines, this is really a crucial and useful component for animation.
These cyclic BlendSpaces are very important for blending in animations whose timescale is supposed to match, such as movement animations, look-at animations, breathing animations, etc...
Currently they only support AnimationNodeAnimation's, since its currently the only way to reliably obtain an AnimationNodes runtime length, which is a hard requirement.
If AnimationNode's had a common interface where each node could return its computed runtime length, then any node could be used in the future, but that is a ton of work and maybe not as crucial for Cyclic BlendSpaces anyways.
Here is a Demo:
https://f.staik.net/f/2de.mp4