Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force duplication of sub-resource to fix make sub-resources unique on MeshInstance #33824

Closed
wants to merge 1 commit into from
Closed

Force duplication of sub-resource to fix make sub-resources unique on MeshInstance #33824

wants to merge 1 commit into from

Conversation

gururise
Copy link
Contributor

@gururise gururise commented Nov 22, 2019

Force duplication of sub-resources on "make sub-resources unique". This fixes #33823

Attached GIF showing this fix works:

@gururise gururise changed the title Force duplication of sub-resource Force duplication of sub-resource to fix make sub-resources unique on MeshInstance Nov 22, 2019
@gururise
Copy link
Contributor Author

FYI, this might be a good cherry pick for 3.1.2 as the bug also affected v3.1.1

@Xrayez
Copy link
Contributor

Xrayez commented Nov 23, 2019

This affects all type of resources though, the question is whether Make Unique should make sub-resources unique as well by default, or should be there another option for that. I think some cases may have cyclic references which could lead to crashes if resources reference each other (because of recursive nature of duplicate(deep=true).

If resources are all built-in, it may be safe to assume that making all sub-resources unique won't crash anything, but I'm not sure what's the proper way of checking that (likely built-in resources have empty resource_path).

@gururise
Copy link
Contributor Author

@Xrayez Agreed. This is probably not the right way to fix the issue.

@gururise gururise closed this Nov 24, 2019
@akien-mga akien-mga added this to the 3.2 milestone Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Make Sub-Resources Unique" does not make MeshInstance Mesh Material Unique
4 participants