HTML5: Explicitly link idbfs.js for IDBFS support #33728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream Emscripten changed this in 1.39.1+, so IDBFS is no longer included by default and has to be linked manually. The explicit linking doesn't seem to be problematic on earlier versions (tested `1.38.47-upstream`). Fixes godotengine#33724.
Member
Author
|
Cherry-picked for 3.1.2. |
Member
Author
|
Cherry-picked for 3.0.7. |
Member
Author
|
Cherry-picked for 2.1.7. |
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jul 31, 2020
Emscripten is a fast-moving target which gets tons of improvements all the time, but it's not rare that some regressions affect us and make our CI builds fail. (See e.g. godotengine#33728, godotengine#35237, godotengine#39168, godotengine#40563, and godotengine#40914.) Let's pin to a stable version to avoid having external factors impact our CI, and update this version manually regularly in a PR to ensure that the new version works well for us.
MarcusElg
pushed a commit
to MarcusElg/godot
that referenced
this pull request
Oct 19, 2020
Emscripten is a fast-moving target which gets tons of improvements all the time, but it's not rare that some regressions affect us and make our CI builds fail. (See e.g. godotengine#33728, godotengine#35237, godotengine#39168, godotengine#40563, and godotengine#40914.) Let's pin to a stable version to avoid having external factors impact our CI, and update this version manually regularly in a PR to ensure that the new version works well for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Emscripten changed this in 1.39.1+, so IDBFS is no longer
included by default and has to be linked manually.
The explicit linking doesn't seem to be problematic on earlier
versions (tested
1.38.47-upstream).Fixes #33724.