WebRTC refactor. data channels, STUN/TURN support. #28964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A big refactor to the WebRTC module. API is now considered quite stable. Highlights: - Renamed `WebRTCPeer` to `WebRTCPeerConnection`. - `WebRTCPeerConnection` no longer act as `PacketPeer`, it only handle the connection itself (a bit like `TCP_Server`) - Added new `WebRTCDataChannel` class which inherits from `PacketPeer` to handle data transfer. - Add `WebRTCPeerConnection.initialize` method to create a new connection with the desired configuration provided as dictionary ([see MDN docs](https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/RTCPeerConnection#RTCConfiguration_dictionary)). - Add `WebRTCPeerConnection.create_data_channel` method to create a data channel for the given connection. The connection must be in `STATE_NEW` as specified by the standard ([see MDN docs for options](https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/createDataChannel#RTCDataChannelInit_dictionary)). - Add a `data_channel_received` signal to `WebRTCPeerConnection` for in-band (not negotiated) channels. - Renamed `WebRTCPeerConnection` `offer_created` signal to `session_description_created`. - Renamed `WebRTCPeerConnection` `new_ice_candidate` signal to `ice_candidate_created`
Faless
changed the title
|
Wow. This is big :) Good work. |
|
Thanks a lot! |
|
why there is no mac os version of binaries |
Because I don't have a Mac to build it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big refactor to the WebRTC module. API is now considered quite stable.
Highlights:
WebRTCPeertoWebRTCPeerConnection.WebRTCPeerConnectionno longer act asPacketPeer, it only handle the connection itself (a bit likeTCP_Server)WebRTCDataChannelclass which inherits fromPacketPeerto handle data transfer.WebRTCPeerConnection.initializemethod to create a new connection with the desired configuration provided as dictionary (see MDN docs).WebRTCPeerConnection.create_data_channelmethod to create a data channel for the given connection. The connection must be inSTATE_NEWas specified by the standard (see MDN docs for options).data_channel_receivedsignal toWebRTCPeerConnectionfor in-band (not negotiated) channels.WebRTCPeerConnectionoffer_createdsignal tosession_description_created.WebRTCPeerConnectionnew_ice_candidatesignal toice_candidate_createdEDIT:
webrtc-native release (binaries win/lin 32/64): https://github.com/Faless/webrtc-native/releases/tag/0.2.90
Demo project (with bundled libraries): https://github.com/Faless/webrtc-native-demo/releases/tag/0.2.90
EDIT2: Added doc screens
