Revert "Revert "Implemented terrain raycast acceleration"" #28928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2019
akien-mga
deleted the
revert-28328-revert-25543-optimize_bullet_heightfield_raycast2
branch
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #28328 i.e. reinstates #25543.
As discussed with @AndreaCatania, we have other changes in bullet/master that we need to use for #28909, so we decided to start tracking bullet/master in the godot/master branch.
The 3.1 branch should however stay compatible with bullet 2.88 stable, so those changes can not be cherry-picked. Hopefully we can get bullet 2.89 released before Godot 3.2, so that our next stable release can also track a stable library version.
The bullet changes in #25543 are not exactly in sync with upstream bullet, but @AndreaCatania will soon do a PR to update our bundled bullet code to an unedited copy of the upstream master branch.