Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GDNativeLibrarySingletonEditor. #28917

Merged

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented May 15, 2019

Moved GDNative singletons discoverer from register_types to GDNativeSingletonEditor.
Fix enable/disable switch in GDNativeLibrarySingletonEditor.
Separate gdnative/singletons and gdnative/singletons_disabled
project settings, keeping "on by default" behavior.
UndoRedo support.

Sample project: proj_singleton.zip

undoredo

Moved GDNative singletons discoverer from register_types to
GDNativeSingletonEditor.
Fix enable/disable switch in GDNativeLibrarySingletonEditor.
Separate `gdnative/singletons` and `gdnative/singletons_disabled`
project settings, keeping "on by default" behavior.
@Faless
Copy link
Collaborator Author

Faless commented May 15, 2019

Note: The menu is currently not working at all due to missing: GDCLASS(GDNativeLibrarySingletonEditor, VBoxContainer); hence the bug tag

Copy link
Contributor

@karroffel karroffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From just looking over it it seems fine! 👍

@akien-mga akien-mga merged commit eded8d5 into godotengine:master May 16, 2019
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants