Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signal connections error dialog #28104

Merged
merged 1 commit into from Apr 29, 2019
Merged

Update signal connections error dialog #28104

merged 1 commit into from Apr 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 16, 2019

Before:
before

After:
after

I wanted to also update the error text (upper-case "Node" and exclamation mark aren't really needed) but I don't know how that'll affect translations, so I left them alone.

@akien-mga
Copy link
Member

I wanted to also update the error text (upper-case "Node" and exclamation mark aren't really needed) but I don't know how that'll affect translations, so I left them alone.

That would mark translations as "fuzzy", which keeps the translated string but the new English one will be used until a translator reviews that fuzzy translation. It's the normal process for updates, so it's fine to make a change now, translators will have time to update before 3.2.

@ghost
Copy link
Author

ghost commented Apr 17, 2019

Thanks for the clarification. I've updated the error messages.

@akien-mga akien-mga merged commit 82fcc99 into godotengine:master Apr 29, 2019
@akien-mga
Copy link
Member

Thanks!

@ghost ghost deleted the connections-error-dialog branch April 29, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants