Added a marker in text_edit that tells which row is executing. #28101
Conversation
MunWolf
force-pushed
the
debugger_cursor
branch
2 times, most recently
from
7106c2e
to
d36b892
Compare
There was a problem hiding this comment.
Nice start!
I'm not too sure on the green dot as it can be pretty hard to see, along with #28218, its going to get pretty crowded, might be clearer as a arrow icon, or always drawing it inline?
More generally, the ScriptEditorDebugger changes feel a bit hacky, it would be clearer for the ScriptEditorDebugger to emit set / clear signals directly, connecting them to the ScriptEditor where needed, as it has direct access.
MunWolf
force-pushed
the
debugger_cursor
branch
from
9b77498
to
3f3aa18
Compare
|
This is the new icon to make it more visible.
|
There was a problem hiding this comment.
Don't know if you want to share the same icon used for the play button, rather then adding a new one?
If not, you'll have to add the icon to: https://github.com/godotengine/godot-design as well.
Otherwise it looks good to me.
MunWolf
force-pushed
the
debugger_cursor
branch
from
3f3aa18
to
9bfa634
Compare
|
Ok didn't see the play cursor, switched to using that one as it was pretty much the same. Cheers! |
|
Thanks! |
|
🎉 |
Fixes: #28081
Added plumbing for passing the current line that is executing to all script editors,
visual editor is the only one that doesn't use it.
Currently shows up as a small green circle in the same place as breakpoints, it is displayed on top of breakpoints.