Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes WAV import being cut in half with new trim code #27927

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

theisegeberg
Copy link

Fixes
#27925 "Trim" option on importing WAV stereo audio removes half of it

@akien-mga
Copy link
Member

Thanks, looks good :)

For the reference, the email you use to sign your commits is not associated with your GitHub account, which is why the commit doesn't appear as authored by "@theisegeberg". That's not a problem as far as Git is concerned, but if you want to change that on GitHub, you can add this email as secondary email in your GitHub settings.

@ghost
Copy link

ghost commented Apr 11, 2019

Thanks for contributing! Can confirm that this fixes the issue. Although the thumbnail rendering of the result audiostream doesn't update on reimport, it's unrelated to this issue.

@akien-mga akien-mga merged commit ceebd74 into godotengine:master Apr 30, 2019
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Note to release managers: should go together with #27645.

@akien-mga
Copy link
Member

Cherry-picked for 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants