Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ONE constants to Vector2 and Vector3 #22808

Merged
merged 2 commits into from
Oct 7, 2018

Conversation

KellyThomas
Copy link
Contributor

@KellyThomas KellyThomas commented Oct 6, 2018

also updates class documentation xml
fixes #22806

@samgreen
Copy link
Contributor

samgreen commented Oct 6, 2018

Haha, well done. You beat me by moments.

@ghost
Copy link

ghost commented Oct 6, 2018

I think it would also be a good idea to add them to Mono, like you did with the original constants in #20901.

@groud groud changed the title add zero constants to Vector2 and Vector3 Add ONE constants to Vector2 and Vector3 Oct 6, 2018
@akien-mga
Copy link
Member

zero

ONE

If that isn't obfuscation 🤔

@KellyThomas
Copy link
Contributor Author

KellyThomas commented Oct 6, 2018

@akien-mga
Thanks, the commit message has been fixed too.

@aaronfranke
Copy link
Member

This PR is missing the documentation changes. https://github.com/godotengine/godot/blob/master/doc/classes/Vector2.xml Note that the doc for zero vectors is wrong (for some reason it's called "Null vector" instead of "Zero vector") so you could fix that up too while you're at it.

@KellyThomas
Copy link
Contributor Author

@aaronfranke Good idea! The documentation has been added.

@akien-mga akien-mga merged commit b17e71b into godotengine:master Oct 7, 2018
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ONE" constant for Vector3/Vector2
4 participants