mono: add IsInstanceValid(), move WeakRef()

[KellyThomas]

No description provided.

[neikeq]

Do you think this may be better as a static method in Godot.Object instead of Godot.GD? This way the class prefix won't be needed when calling it from Godot.Object derived classes, which I think is the majority of the time.

[aaronfranke]

@neikeq If you make an extension to Godot.Object, it may be best to merge this PR first.

[KellyThomas]

@neikeq I agree with that reasoning and have moved it over to the Object class.

By the same logic we could consider moving FuncRef() and WeakRef() as well. What do you think?

@aaronfranke I will be happy enough to rework this to suit #20707 if required.

[neikeq]

By the same logic we could consider moving FuncRef() and WeakRef() as well. What do you think?

The reason to have IsInstanceValid in Object was not only because it makes it less verbose to use, but also that the method is related to this class. FuncRef() is not related to Obect. WeakRef() sounds good.

[KellyThomas]

OK, I have moved WeakRef() over.

[neikeq]

Thanks!

[akien-mga]

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.