Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Improvements to GD.cs: PascalCasing and real_t #20337

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

aaronfranke
Copy link
Member

I've made a few improvements to GD.cs. Some of the functions, which originally lacked _ between words in snake_case, were lacking capital letters in PascalCase, but should have them. Let me know if I capitalized something that wasn't supposed to be capitalized. I wasn't too sure about PrintS for example.

I've also replaced the floating types with real_t for the few math functions present. Interestingly, one of the db functions was double-only before while the other was float-only? Strange.

[Mono] Improvements to GD.cs: PascalCasing and real_t
@neikeq
Copy link
Contributor

neikeq commented Jul 22, 2018

Looks good to me.

@neikeq neikeq merged commit 525384d into godotengine:master Jul 22, 2018
@aaronfranke aaronfranke deleted the mono-pascal-gd branch July 22, 2018 20:17
@hpvb
Copy link
Member

hpvb commented Jul 27, 2018

Cherry picked into 3.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants