Expose methods to set individual border colors in StyleBoxFlat #16899
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in colours in StyleBoxFlat class as is consistent with internal class behaviour, and replaced original functionality set_border_color_all method too.
|
This breaks compatibility with 3.0, so we can't merge it as is. The proposed API makes sense, but we'll have to use another one for now and maybe document that in #16863 for the next compatibility breakage. |
|
Closing for now as I can't merge it as is due to the compatibility breakage. It would still be an interesting addition if done in a non-breaking way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made set_border_color script method allow for setting individual margin colours in
StyleBoxFlat class as is consistent with internal class behaviour, and replaced
original functionality set_border_color_all method too.