Skip to content

Capitalize ARM in editor properties#118880

Open
slalomsquid wants to merge 1 commit into
godotengine:masterfrom
slalomsquid:capitalised-arm
Open

Capitalize ARM in editor properties#118880
slalomsquid wants to merge 1 commit into
godotengine:masterfrom
slalomsquid:capitalised-arm

Conversation

@slalomsquid
Copy link
Copy Markdown

In the file editor_property_name_processor.cpp, the variable is called capitalize_string_remaps and it makes more sense to use the capital ARM as it's an acronym. So I have changed arm32, arm64, arm64-v8a, armeabi-v7a to be ARM.

Capitalise ARM in editor properties
@slalomsquid slalomsquid requested a review from a team as a code owner April 23, 2026 07:45
@arkology
Copy link
Copy Markdown
Contributor

it makes more sense to use the capital ARM as it's an acronym. So I have changed arm32, arm64, arm64-v8a, armeabi-v7a to be ARM.

Questionable.
See https://developer.android.com/ndk/guides/abis

@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Apr 23, 2026

Related: #117072 (comment)

@dalexeev
Copy link
Copy Markdown
Member

dalexeev commented Apr 23, 2026

This can also conflict with XR. For example, there is the XRBodyTracker.Joint enum. If the constants JOINT_{LEFT,RIGHT}_{UPPER,LOWER}_ARM are displayed somewhere in the inspector, "arm" will be capitalized instead of using Title Case. Custom properties or enum elements can also have "arm" in their names, probably more often meaning "body part" rather than "hardware platform".

EDIT. After I wrote my comment, I noticed that the mappings use specific platform names (with suffixes), rather than just the generic name "arm". If this PR is approved, perhaps it would be worth adding a comment to the code explaining why we shouldn't use the generic name in the mappings, but list each platform separately.

@AThousandShips
Copy link
Copy Markdown
Member

I think it unlikely for someone to put arm32 in their properties

@bruvzg
Copy link
Copy Markdown
Member

bruvzg commented Apr 23, 2026

It's pretty common to see ARM capitalized, but logo is all lower case and www.arm.com does not capitalize, neither do Microsoft.

@AThousandShips AThousandShips changed the title Capitalise ARM in editor properties Capitalize ARM in editor properties Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants