Skip to content

Add a bunch of missing window existence checks to HDR methods#118680

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
bruvzg:hdr_wnd_chk
Apr 18, 2026
Merged

Add a bunch of missing window existence checks to HDR methods#118680
Repiteo merged 1 commit into
godotengine:masterfrom
bruvzg:hdr_wnd_chk

Conversation

@bruvzg
Copy link
Copy Markdown
Member

@bruvzg bruvzg commented Apr 17, 2026

See #118672

Supersede #118669

Crash is not practically reproducible (require exact timing of highly unlikely events), but it is user accessible functions and calling it with invalid argument will result in addition of corrupted window data.

@bruvzg bruvzg added this to the 4.7 milestone Apr 17, 2026
@bruvzg bruvzg requested review from a team as code owners April 17, 2026 12:50
@bruvzg bruvzg added the bug label Apr 17, 2026
@bruvzg bruvzg requested a review from a team as a code owner April 17, 2026 12:50
@bruvzg bruvzg changed the title Add a bunch of missing window existence checks to HDR methods, Add a bunch of missing window existence checks to HDR methods Apr 17, 2026
Comment thread platform/macos/display_server_macos.h Outdated
@Repiteo Repiteo merged commit 1d218e6 into godotengine:master Apr 18, 2026
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Apr 18, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants