Skip to content

Finish mapping missing deprecated types for GDExtension#118563

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Mister-Ky:patch-2
Apr 21, 2026
Merged

Finish mapping missing deprecated types for GDExtension#118563
Repiteo merged 1 commit into
godotengine:masterfrom
Mister-Ky:patch-2

Conversation

@Mister-Ky
Copy link
Copy Markdown
Contributor

Refined #107845

Comment thread core/extension/gdextension_interface.json Outdated
@dsnopek
Copy link
Copy Markdown
Contributor

dsnopek commented Apr 19, 2026

Thanks! These changes look good to me :-)

Can you rebase and squash this into a single commit?

See https://contributing.godotengine.org/en/latest/pull_requests/creating_pull_requests.html#the-interactive-rebase

@Mister-Ky Mister-Ky force-pushed the patch-2 branch 2 times, most recently from 67d09ac to 5419d88 Compare April 20, 2026 20:48
@Mister-Ky
Copy link
Copy Markdown
Contributor Author

@dsnopek Rebase and squash complete. Fixed the merge conflict with the recent changes as well.

Copy link
Copy Markdown
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I noticed two mistakes in your latest changes (see below) but they are probably due to some other mistakes from #118214 which incorrectly say that classdb_register_extension_class6 and classdb_construct_object3 were "since" 4.6, but actually, those are since 4.7

Would you mind updating those in your PR as well?

Comment thread core/extension/gdextension_interface.json Outdated
Comment thread core/extension/gdextension_interface.json Outdated
@Mister-Ky
Copy link
Copy Markdown
Contributor Author

@dsnopek Done!

@Mister-Ky
Copy link
Copy Markdown
Contributor Author

I have corrected "since" from another PR as you said

@dsnopek dsnopek added the bug label Apr 21, 2026
@dsnopek dsnopek modified the milestones: 4.x, 4.7 Apr 21, 2026
Copy link
Copy Markdown
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great to me :-)

I've added the bug label and switched this to the 4.7 milestone, because this now also fixes some mistakes from #118214 which should be included in the 4.7 release

@Repiteo Repiteo merged commit 81cecf0 into godotengine:master Apr 21, 2026
7 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Apr 21, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants