Finish mapping missing deprecated types for GDExtension#118563
Merged
Conversation
Mister-Ky
commented
Apr 14, 2026
Contributor
|
Thanks! These changes look good to me :-) Can you rebase and squash this into a single commit? |
67d09ac to
5419d88
Compare
Contributor
Author
|
@dsnopek Rebase and squash complete. Fixed the merge conflict with the recent changes as well. |
dsnopek
reviewed
Apr 20, 2026
Contributor
dsnopek
left a comment
There was a problem hiding this comment.
Thanks!
I noticed two mistakes in your latest changes (see below) but they are probably due to some other mistakes from #118214 which incorrectly say that classdb_register_extension_class6 and classdb_construct_object3 were "since" 4.6, but actually, those are since 4.7
Would you mind updating those in your PR as well?
Contributor
Author
|
@dsnopek Done! |
Contributor
Author
|
I have corrected "since" from another PR as you said |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refined #107845