Skip to content

Metal: Fix crash accessing NULL PixelFormats #117744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akien-mga merged 1 commit into from
Mar 23, 2026
Merged

Metal: Fix crash accessing NULL PixelFormats #117744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/metal/rendering_device_driver_metal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2848,6 +2848,7 @@ Error RenderingDeviceDriverMetal::_initialize(uint32_t p_device_index, uint32_t
ERR_FAIL_COND_V(err, ERR_CANT_CREATE);

device_properties = memnew(MetalDeviceProperties(device));
pixel_formats = memnew(PixelFormats(device, device_properties->features));
device_profile = device_profile_from_properties(device_properties);
resource_cache = std::make_unique<MDResourceCache>(device, *pixel_formats, device_properties->limits.maxPerStageBufferCount);
shader_container_format = memnew(RenderingShaderContainerFormatMetal(&device_profile));
Expand All @@ -2862,7 +2863,6 @@ Error RenderingDeviceDriverMetal::_initialize(uint32_t p_device_index, uint32_t
// Set the pipeline cache ID based on the Metal version.
pipeline_cache_id = "metal-driver-" + get_api_version();

pixel_formats = memnew(PixelFormats(device, device_properties->features));
if (device_properties->features.layeredRendering) {
multiview_capabilities.is_supported = true;
multiview_capabilities.max_view_count = device_properties->limits.maxViewports;
Expand Down
Loading