Call stop after setting new sprite frames#117655
Merged
Merged
Conversation
Member
That project still fails xd 
But the MPR from the issue confirms the fix. |
KoBeWi
approved these changes
Mar 20, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86058
Calling
stopafter setting new sprite frames fixes the bug by calling indirectlyset_frame_and_progressafter new frame duration data is available.Order of emitted signals is preserved, at least I couldn't find a way to change it in the test code.
Fixing it like this does not introduce any new code.
There's old stale PR #86277 which could be closed if this one gets merged.
Test project: frameduration.zip