CI: Implement clangd-tidy as GitHub Action#117654
Conversation
b8e4117 to
84c7106
Compare
|
Does it currently pass if running manually on all files (except the ones excluded by the changed-files logic)? Also, running it on all files is pretty slow (more than one hour on my laptop) so it may timeout on CI. This may turn out to be problematic on big codebase wide changes. If so we might want to put a threshold on how many files the changed-files action returns, and bail out if it's too high. |
7961041 to
1ebe2eb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a8d56dd to
39ef375
Compare
39ef375 to
5538887
Compare
e11e8ba to
06cef35
Compare
|
The workflow now passes when run across all filtered files! What's more: the time it would take to run against every passable file is ~45 minutes1, so undeniably a step up from the speed of Footnotes |
06cef35 to
0e8bd28
Compare
|
Thanks! Great work 🎉 |
Replaces our current
clang-tidychecker in CI with aclangd-tidyequivalent. This integrates the more lightweight checker in a way that's directly integrated with our repository & should have a wider coverage than theclang-tidypre-commit hookExample output on filtered files can be viewed on this runner from a dummy commit.