Skip to content

Allow overriding SpinBox buttons' side#117470

Open
vaner-org wants to merge 2 commits into
godotengine:masterfrom
vaner-org:spinbox-buttons-side
Open

Allow overriding SpinBox buttons' side#117470
vaner-org wants to merge 2 commits into
godotengine:masterfrom
vaner-org:spinbox-buttons-side

Conversation

@vaner-org
Copy link
Copy Markdown
Contributor

@vaner-org vaner-org commented Mar 16, 2026

Closes #14470. Created for #117498.

Adds Button Alignment parameter to SpinBox with Default, Left and Right choices.

spinboxes

@vaner-org vaner-org requested review from a team as code owners March 16, 2026 10:50
@AThousandShips AThousandShips added this to the 4.x milestone Mar 16, 2026
@vaner-org vaner-org force-pushed the spinbox-buttons-side branch 2 times, most recently from 1455b16 to 1e339c8 Compare March 16, 2026 10:57
@AThousandShips
Copy link
Copy Markdown
Member

Please set up clang-format locally to help with formatting

@vaner-org vaner-org force-pushed the spinbox-buttons-side branch from 1e339c8 to 926be84 Compare March 16, 2026 10:59
@SWKrefs
Copy link
Copy Markdown

SWKrefs commented Mar 16, 2026

What is different about this compared to switching 'Layout Direction'?

@vaner-org
Copy link
Copy Markdown
Contributor Author

Layout Direction also inverts anchors, which might not be desired.

Comment thread scene/gui/spin_box.cpp Outdated
Comment thread scene/gui/spin_box.cpp Outdated
Comment thread scene/gui/spin_box.cpp Outdated
Comment thread scene/gui/spin_box.cpp Outdated
Comment thread scene/gui/spin_box.h Outdated
@vaner-org vaner-org force-pushed the spinbox-buttons-side branch 3 times, most recently from d6a1d4f to 3f18983 Compare March 19, 2026 09:37
@vaner-org vaner-org requested review from a team as code owners April 8, 2026 22:44
@vaner-org
Copy link
Copy Markdown
Contributor Author

This has now inherited the SpinBox changes for BlendSpace editors, so that the approved PR may make it to 4.7.

@vaner-org vaner-org force-pushed the spinbox-buttons-side branch from 723d498 to 979cacd Compare April 9, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow manually setting SpinBox buttons side

3 participants