Skip to content

[macOS/Windows] Remove dynamically linked ANGLE support, add flag to enable/disable ANGLE.#117445

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:angle_no_dyn
Mar 26, 2026
Merged

[macOS/Windows] Remove dynamically linked ANGLE support, add flag to enable/disable ANGLE.#117445
akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:angle_no_dyn

Conversation

@bruvzg
Copy link
Copy Markdown
Member

@bruvzg bruvzg commented Mar 15, 2026

Supersede #109889
Same as #117313 for ANGLE.

  • Adds angle build flag to fully enable/disable ANGLE (defaults to true.
  • If libs are missing, warning is printed and angle is set to false.

Note: since there's #109889, I have not added an installation script or lookup in the deps folder. Added the script from #109889 instead.

@bruvzg bruvzg added this to the 4.x milestone Mar 15, 2026
@bruvzg bruvzg marked this pull request as ready for review March 16, 2026 09:12
@bruvzg bruvzg requested review from a team as code owners March 16, 2026 09:12
Copy link
Copy Markdown
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Linux + WINE, it works as expected.

I've seen very little use of dynamically linked ANGLE in Godot projects in the wild, so I agree with this change.

Note that this is a "soft dependency", and compilation will continue with ANGLE disabled if the libraries haven't been downloaded. This is similar to AccessKit, but different from Direct3D 12 which will abort compilation unless you pass d3d12=no explicitly. I think this makes sense considered Compatibility isn't used as often as Forward+/Mobile on desktop, but maybe there is an argument to making it a hard dependency like D3D12 (with angle=no needing to be explicitly passed if missing).

Comment thread platform/macos/display_server_macos.mm
Comment thread platform/macos/detect.py Outdated
@bruvzg bruvzg force-pushed the angle_no_dyn branch 2 times, most recently from d024837 to fc82ffd Compare March 20, 2026 14:08
@akien-mga akien-mga modified the milestones: 4.x, 4.7 Mar 23, 2026
Comment thread platform/linuxbsd/wayland/detect_prime_egl.h
Comment thread platform/linuxbsd/x11/detect_prime_x11.cpp Outdated
Comment thread SConstruct Outdated
…enable/disable ANGLE.

Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
@akien-mga akien-mga merged commit e030230 into godotengine:master Mar 26, 2026
20 checks passed
@akien-mga
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants