Metal: Fix offscreen rendering in context driver.#117192
Merged
Merged
Conversation
bruvzg
approved these changes
Mar 8, 2026
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
I can't reproduce crash, but it is spamming pipeline creation errors which is fixed by this PR.
Note for testing: relevant env variable is GODOT_MTL_OFF_SCREEN (with underscore after OFF).
Contributor
Author
|
Thanks @bruvzg – sorry for the misspelling of the environment variable. And you are right, it wasn't a crash, but it failed to create pipelines and spammed the logs. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results in a crash when specifying the GODOT_MTL_OFF_SCREEN=1 environment variable. Introduced by #106814