Restrict textureGather shader function in Compatibility mode#117157
Merged
Repiteo merged 1 commit intoMar 12, 2026
Conversation
dujanhung
approved these changes
Mar 7, 2026
Member
|
Pack and unpack should not be removed |
Chaosus
force-pushed
the
shader_restrict_uncompatible_funcs
branch
from
ea65e50 to
4e55814
Compare
Chaosus
changed the title
Chaosus
force-pushed
the
shader_restrict_uncompatible_funcs
branch
from
4e55814 to
3085aaf
Compare
Chaosus
changed the title
textureGather shader function in Compatibility mode
Calinou
approved these changes
Mar 11, 2026
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
For reference, textureGather() is only available in OpenGL 4.0 and later. It's not available in OpenGL ES 3.0 and WebGL 2.0, which would lead to shader compilation failures once you export to mobile/web platforms.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've detected that
textureGatherare not supported in Compatibility renderer mode and lead to shader crash even in the editor.