Skip to content

Provide default values for fold state in "Edit Animation Libraries" window to prevent errors#116295

Merged
Repiteo merged 0 commit into
godotengine:masterfrom
Meorge:bugfix/anim-library-folding
Feb 17, 2026
Merged

Provide default values for fold state in "Edit Animation Libraries" window to prevent errors#116295
Repiteo merged 0 commit into
godotengine:masterfrom
Meorge:bugfix/anim-library-folding

Conversation

@Meorge
Copy link
Copy Markdown
Contributor

@Meorge Meorge commented Feb 14, 2026

Closes #116293.

The "Edit Animation Libraries" window would try to get folding data even if the file with that data had not been created yet. Because no default value was provided, the error described in #116293 would be thrown.

This PR provides empty PackedStringArrays as default values for these get_value() calls, so that if there is no folding data, the editor considers no sections to be folded.

@Meorge Meorge requested review from a team as code owners February 14, 2026 16:07
Comment thread editor/animation/animation_library_editor.cpp Outdated
@Meorge Meorge force-pushed the bugfix/anim-library-folding branch from 0bf0213 to ad570e8 Compare February 14, 2026 23:23
@AThousandShips AThousandShips added this to the 4.7 milestone Feb 16, 2026
@Repiteo Repiteo merged commit 8ab040c into godotengine:master Feb 17, 2026
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Feb 17, 2026

Thanks!

@Meorge Meorge deleted the bugfix/anim-library-folding branch February 18, 2026 01:31
@akien-mga
Copy link
Copy Markdown
Member

For the record, GitHub seems bugged out on this merge batch and the PR view shows "0 commits", but the commit which was merged is indeed present in the master branch: ad570e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Couldn't find the given section "[hash or UID]" and key "folding", and no default was given" when opening "Edit Animation Libraries" window

5 participants