[Windows] Implement OneCore TTS support using C++/WinRT.#116126
Conversation
| #include "core/variant/array.h" | ||
|
|
||
| GODOT_CLANG_WARNING_PUSH | ||
| GODOT_CLANG_WARNING_IGNORE("-Wdeprecated-pragma") // Note: remove after switching to C++20. |
There was a problem hiding this comment.
Note: Added to suppress ./core/os/spin_lock.h:96:38: warning: macro 'ATOMIC_VAR_INIT' has been marked as deprecated [-Wdeprecated-pragma] warnings, since these files require C++20. Should be removed when the rest of the code is switched to C++20.
3bbe7cd to
4e9b5c6
Compare
|
Why do we need to vendor winrt headers? Aren't they part of the Windows SDK? I'm not fond of adding 120k lines of code to solve this issue. Maybe it can be trimmed down to only the subset of headers we are using, which might be much less files? |
On Windows with MSVC, we do not, but it's not part of MinGW (MSYS has it as a separate package, most MinGW distributions doesn't have them at all, there are some headers of Win32 For the reference, trimmed down from |
1838bf0 to
bc3b35e
Compare
Editing the files is possible but won't be maintainable. Since it's likely we'll need WinRT API for other stuff in the future, it might be reasonable to make a separate repo with full set of pre-build headers. And add For the reference, few other uses that can benefit from WinRT API:
|
Made an alternative version of this PR which uses build option and download script for WinRT headers - #116349 |
|
Superseded by #116349. |
Fixes #69788
Tested on Windows 11 (25H2) and Windows 10 (22H2).
Notes: