Use RawInput + Windows.Gaming.Input on Windows#116101
Closed
Nintorch wants to merge 1 commit intogodotengine:masterfrom
Closed
Use RawInput + Windows.Gaming.Input on Windows#116101Nintorch wants to merge 1 commit intogodotengine:masterfrom
Nintorch wants to merge 1 commit intogodotengine:masterfrom
Conversation
18 tasks
Contributor
Author
|
I just tried Xbox One's trigger rumble for the first time! |
2 tasks
Contributor
Author
|
Superseded by #116055 , but if that PR won't work out we can re-open this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #116055
Closes godotengine/godot-proposals#8620
Instead of possibly doing a lot of work to introduce GameInput and remove DirectInput/XInput, this PR enables the RawInput backend for SDL that also uses "Windows.Gaming.Input" API to better handle more than 4 XInput controllers without removing previous drivers in the short term.
Advantages:
Small disadvantages:
xinput_indexfield ofInput.get_joy_info()won't be available unless we explicitly disable RawInput through SDL_JOYSTICK_RAWINPUT environment variableCompared to the GameInput solution, this one doesn't allow Godot games to be published in Microsoft Store 😅(note that it's a small/negligible disadvantage)No longer the case.TODO:
xinput_indexbeing missing