Remove unused JoypadSDL::singleton#115952
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Feb 6, 2026
Merged
Conversation
akien-mga
approved these changes
Feb 6, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Singleton functionality for
JoypadSDLwas added in #106218 and it seems to be a leftover from xsellier's commit (I'm not sure what was its purpose there and I didn't think about deleting it in my PR).Since it's unused and it can not be used in
Inputclass (because it would break encapsulation), I think it should be removed.