libjpeg-turbo: Improve config files and fix patches#115879
libjpeg-turbo: Improve config files and fix patches#115879Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
|
Looks fine to me, sorry for making it a bit of a burden to update with the cmake conversion and patch stuff. I wonder if we could just use cmake in the build process and then use the library files it generates, or at least the headers... that is probably more painful than what we have now though and I guess we hopefully don't need to update it that often. |
|
Using CMake would be a net negative here IMO, as it would add a dependency, and in my experience CMake is a pain for cross-compilation (at least for the kind of advanced cross-compilation needs we have). We're also not building for the host platform (what CMake does) but for a target which may have different capabilities, even on the same OS family or architecture. (E.g. compiling on a Linux machine that supports AVX but we want to limit ourselves to SSE4.2.) So making explicit decisions in our config is better IMO. It's not too much burden here and should indeed not change too much in the future, I just messed up my last sync. The main burden is the hardcoded On the other hand we could maybe remove the Edit: Hm no let's keep them as a patch, it's easier to restore them on update. |
46c3e81 to
345cbe3
Compare
|
Thanks! |
…eanup-config libjpeg-turbo: Improve config files and fix patches
Fixing a few minor issues with the libjpeg-turbo config:
BUILDis the date of generating the config, I replaced it with "Godot" (it's used in an info string)NO_PUTENV/NO_GETENV, they're only used for niche environment variable hacks to override the SIMD CPU support (which we don't enable anyway) or the default memory manager's max memory.HIDDENandINLINEdefines for the 21st century.HAVE_INTRIN_Hfor MSVC.CC @DanielKinsman