Geometry2D: Remove arc_tolerance scaling and the comment related to that.#115293
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 24, 2026
Merged
Geometry2D: Remove arc_tolerance scaling and the comment related to that.#115293akien-mga merged 1 commit intogodotengine:masterfrom
arc_tolerance scaling and the comment related to that.#115293akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
clipper2 1.5.3 does the scaling internally.
AThousandShips
changed the title
arc_tolerance scaling and the comment related to that.
akien-mga
approved these changes
Jan 23, 2026
Member
akien-mga
left a comment
akien-mga
left a comment
There was a problem hiding this comment.
This was indeed changed in AngusJohnson/Clipper2@ca6e8fd.
Sadly they don't give a changelog nor pointed it out as a breaking change :|
So this fixes a regression 4.5+.
akien-mga
added
regression
cherrypick:4.5
akien-mga
removed
the
cherrypick:4.6
Member
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113263
This broke with the upgrade to clipper2 1.5.3 which does the arc_tolerance scaling internally.
See commit