Renderer: Simplify shader and cluster builder#115108
Merged
akien-mga merged 1 commit intoMar 23, 2026
Merged
Conversation
- gl_HelperInvocation + MSAA is the root cause of the rendering artifacts. - Disable the gl_HelperInvocation check using a specialisation constant, which removes two variants from compilation - Remove NO_IMAGE_ATOMICS variant, as the macros are not used in cluster_render.glsl, removing a further two variants.
clayjohn
approved these changes
Mar 23, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify cluster_builder code
gl_HelperInvocation+ MSAA is the root cause of the rendering artifacts.gl_HelperInvocationcheck using a specialisation constant, which removes two variants from compilationNO_IMAGE_ATOMICSvariant, as the macros are not used in cluster_render.glsl, removing a further two variants.Important
I didn't observe any noticeable impact on perf.
For reference, the rendering artefacts looked like the following when MSAA is enabled and
gl_HelperInvocationis used: