Windows: Add missing extern "C" for hidsdi.h on MinGW < 12.0.0
#115010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
platform:windows
topic:buildsystem
regression
cherrypick:4.5
akien-mga
force-pushed
the
windows-mingw-fix-hidsdi-extern-c
branch
from
638c217 to
dac1721
Compare
akien-mga
commented
Jan 15, 2026
Comment on lines
+67
to
+74
| // Workaround missing `extern "C"` in MinGW-w64 < 12.0.0. | ||
| #if defined(__MINGW32__) && (!defined(__MINGW64_VERSION_MAJOR) || __MINGW64_VERSION_MAJOR < 12) | ||
| extern "C" { | ||
| #include <hidsdi.h> | ||
| } | ||
| #else | ||
| #include <hidsdi.h> | ||
| #endif |
Member
Author
There was a problem hiding this comment.
Alternatively, both are a bit messy:
Suggested change
| // Workaround missing `extern "C"` in MinGW-w64 < 12.0.0. | |
| #if defined(__MINGW32__) && (!defined(__MINGW64_VERSION_MAJOR) || __MINGW64_VERSION_MAJOR < 12) | |
| extern "C" { | |
| #include <hidsdi.h> | |
| } | |
| #else | |
| #include <hidsdi.h> | |
| #endif | |
| // Workaround missing `extern "C"` in MinGW-w64 < 12.0.0. | |
| #if defined(__MINGW32__) && (!defined(__MINGW64_VERSION_MAJOR) || __MINGW64_VERSION_MAJOR < 12) | |
| extern "C" { | |
| #endif | |
| #include <hidsdi.h> | |
| #if defined(__MINGW32__) && (!defined(__MINGW64_VERSION_MAJOR) || __MINGW64_VERSION_MAJOR < 12) | |
| } | |
| #endif |
|
Yes it builds for me on Ubuntu 24.04 with this change. |
Member
Author
|
Cherry-picked for 4.5.2. (Ahead of the likely merge of this PR, as I want to include it in 4.5.2.rc1.) |
akien-mga
removed
the
cherrypick:4.5
bruvzg
approved these changes
Jan 16, 2026
| #include <winternl.h> | ||
|
|
||
| // Workaround missing `extern "C"` in MinGW-w64 < 12.0.0. | ||
| #if defined(__MINGW32__) && (!defined(__MINGW64_VERSION_MAJOR) || __MINGW64_VERSION_MAJOR < 12) |
Member
There was a problem hiding this comment.
Nested extern "C"s should not do anything (at least when header has it in #ifdef __cplusplus, which newer MinGW does), so version check can be omitted, but I guess it's better to still have it to make it clear it is MinGW issue.
Member
Author
There was a problem hiding this comment.
Yeah I mostly added it for documentation purposes, so we don't refactor this to remove the unnecessary check for modern compilers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #113013.
Works for me on Fedora 40 with MinGW 11.0.1.
Does it work for you too on Ubuntu 24.04 @BuzzLord?