[4.5] Cherry-picks for the 4.5 branch (future 4.5.2) - 3rd batch #114768
+1,712
−820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 717a7f1)
This action has never worked due to permission issues, and because of how GitHub handles caches it wouldn't reliably help cache anyway. (cherry picked from commit 2f4234d)
Without this, on Linux and Linux alone, and only if SDL is builtin, the definitions for some functions - notably, memset/memcpy - are taken from SDL source. This leaves them at the mercy of the compiler and may lead to the optimal implementations of these functions not being selected. But the main motivation for this is that it's action at a distance that is incredibly surprising - linking in a gamepad support library should not change the implementation of memset/memcpy! (cherry picked from commit dcefe95)
(cherry picked from commit 2b35019)
(cherry picked from commit 259d95f)
(cherry picked from commit 9de2837)
(cherry picked from commit 1036bfd)
(cherry picked from commit 9993438)
(cherry picked from commit 817bf95)
(cherry picked from commit e6f441e)
…_from_variant`. (cherry picked from commit e815a8f)
(cherry picked from commit 3d4f248)
(cherry picked from commit 4266a4e)
main.cpp uses "profile-gpu" in one place, whereas all other occurrences in the codebase use "gpu-profile". This fixes the gpu profiler not being configurable via CLI. (cherry picked from commit b1621df)
Script assignment must be complete for the subtree in order to correctly assign into properties set to a script type. (cherry picked from commit b9cc82d)
Co-authored-by: kleonc <[email protected]> (cherry picked from commit a9ef3e5)
…MODE_IGNORE (cherry picked from commit 49efe2b)
…rame This fixes issues with certain video formats (like OGV) and video players not supporting resolution changes during playback. Resizing the viewport during recording is still not recommended (as cropping and resizing has a performance cost and can impact visuals), but it shouldn't cause crashes or broken files anymore. (cherry picked from commit 4409c78)
(cherry picked from commit 1af77aa)
(cherry picked from commit afe8798)
(cherry picked from commit 87bbad5)
akien-mga
force-pushed
the
4.5-cherrypicks-misc
branch
2 times, most recently
from
fc7edde to
5034479
Compare
(cherry picked from commit 199a4fa)
(cherry picked from commit 2914a87)
(cherry picked from commit eaa643a)
(cherry picked from commit 7768dea)
(cherry picked from commit 3f98a54)
…tor to Ref<TileSetScenesCollectionSource> (cherry picked from commit ea1cc3c)
(cherry picked from commit 3f1d973)
(cherry picked from commit f18a33f)
akien-mga
force-pushed
the
4.5-cherrypicks-misc
branch
from
5034479 to
26547f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #114746 (rendering) and #114762 (platforms), this covers a misc collection of areas, namely:
I still need to do a pass on editor/gui PRs, either to add here or in another batch.