Skip to content

Fix problems with popup menus for Tree's range items #114760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
YeldhamDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix problems with popup menus for Tree's range items #114760

YeldhamDev wants to merge 1 commit into from
+12 −2

Conversation

@YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Jan 8, 2026

  • Fix incorrect position when popping up.
  • Fix popup width not matching the item width.
  • Fix position ignoring right-to-left layout.
Before After
Screenshot_20260108_164451 Screenshot_20260108_164226

@YeldhamDev YeldhamDev added this to the 4.6 milestone Jan 8, 2026
@YeldhamDev YeldhamDev requested a review from a team as a code owner January 8, 2026 20:27
akien-mga
akien-mga previously approved these changes Jan 8, 2026
View reviewed changes
@akien-mga
Copy link
Member

akien-mga commented Jan 8, 2026

See #114438 which added width shrinking. CC @bruvzg.

@akien-mga akien-mga dismissed their stale review January 8, 2026 21:10

Should be reviewed by bruvzg.

@akien-mga akien-mga requested a review from bruvzg January 8, 2026 21:11
@akien-mga akien-mga mentioned this pull request Jan 9, 2026
Open
Clubhouse1661 added a commit to Clubhouse1661/godot that referenced this pull request Jan 9, 2026
@Clubhouse1661
Fix OptionButton PopupMenu not shrinking after item changes
dfc945e 
Fixes godotengine#114786. Reset min_size before popup to prevent clamping to old size, enable shrink_height, and move shrink_width to constructor following PR godotengine#114760 style.
Clubhouse1661 added a commit to Clubhouse1661/godot that referenced this pull request Jan 9, 2026
@Clubhouse1661
Fix OptionButton PopupMenu not shrinking after item changes
72ed25e 
Fixes godotengine#114786. Reset min_size before popup to prevent clamping to old size. Move shrink_width to constructor following PR godotengine#114760 style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruvzg bruvzg bruvzg approved these changes

@akien-mga akien-mga akien-mga left review comments

Assignees

No one assigned

Labels

bug topic:gui

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

3 participants

@YeldhamDev @akien-mga @bruvzg