Add start/end build timestamps#114754
Conversation
|
This is an interesting idea, but I think showing the UTC time alone is enough (so it's more compact). If you really want to show local time, perhaps it should be done on the same line after UTC time. All in all, I would try to compact the display from 3 lines to just 1. Maybe you can even put this information on the same line as "Time elapsed" as follows:
I would also clean up the timestamp a little to be more readable (remove milliseconds, and replace |
|
@Calinou I updated my PR following your suggestion! |
c7308b7 to
c6f3020
Compare
c6f3020 to
4091325
Compare
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected.
However, I'm not sure we need the added complexity from an option to choose between printing UTC and local time. I would settle on one or the other (but probably UTC, since it matches what Godot prints on startup for the Git commit date).
This PR adds a timestamp at the beginning of builds, and at the end also.
So many times, I trigger a build again because I cannot differentiate an old build from a new in my terminal.
Note
Updated my PR following @Calinou's suggestion.
Features:
build_timestamp_timezone: Determines which timezone to use to print build timestamps in SCons terminal output. Defaults to `utc` (utc|system)datetimefor all timestamp calculation (including the build time)Start of the build
Plain text
Picture
End of the build
Plain text
Picture