Skip to content

GDScript: Reuse scripts from ResourceCache #114623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HolonProduction wants to merge 1 commit into from
Closed

GDScript: Reuse scripts from ResourceCache #114623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions modules/gdscript/gdscript_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,13 @@ Ref<GDScript> GDScriptCache::get_shallow_script(const String &p_path, Error &r_e

const String remapped_path = ResourceLoader::path_remap(p_path);

Ref<GDScript> script;
script.instantiate();
// HACK: When this code runs there should not be an entry in the resource cache. However some bug with cyclic references
// can lead to a partially destructed script in the cache: GH-98141. We reconstruct the script in the same place
// to prevent the creation of a duplicate.
Ref<GDScript> script = ResourceCache::get_ref(p_path);
if (script.is_null()) {
script.instantiate();
}

script->set_path_cache(p_path);
if (remapped_path.has_extension("gdc")) {
Expand Down
Loading