Skip to content

Fix real time reflection probes being constantly recreated. #114281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akien-mga merged 1 commit into from
Dec 22, 2025
Merged

Fix real time reflection probes being constantly recreated. #114281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions servers/rendering/renderer_rd/storage_rd/light_storage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,14 +1511,13 @@ bool LightStorage::reflection_probe_instance_begin_render(RID p_instance, RID p_
// but not the other way around. This can lead to situations where the reflection atlas will be stuck on a lower resolution
// even if no real-time probes are present. This is intentional behavior until a future solution can accommodate for both
// quality levels being used simultaneously.
const int required_real_time_mipmaps = 7;
const bool switched_to_real_time = !atlas->update_always && update_always && atlas->reflection.is_valid();
const bool real_time_mipmaps_different = update_always && atlas->reflection.is_valid() && atlas->reflections[0].data.layers[0].mipmaps.size() != 8;
const bool real_time_mipmaps_different = update_always && atlas->reflection.is_valid() && atlas->reflections[0].data.layers[0].mipmaps.size() != required_real_time_mipmaps;
if (switched_to_real_time || real_time_mipmaps_different) {
_reflection_atlas_clear(atlas);
}

const int required_real_time_mipmaps = 7;

if (atlas->reflection.is_null()) {
RendererRD::CopyEffects *copy_effects = RendererRD::CopyEffects::get_singleton();
ERR_FAIL_NULL_V_MSG(copy_effects, false, "Effects haven't been initialized");
Expand Down