Skip to content

Skip over non-CanvasItem parents when selecting texture filter properties.#113883

Closed
bruvzg wants to merge 1 commit into
godotengine:masterfrom
bruvzg:ci_filter_lookup
Closed

Skip over non-CanvasItem parents when selecting texture filter properties.#113883
bruvzg wants to merge 1 commit into
godotengine:masterfrom
bruvzg:ci_filter_lookup

Conversation

@bruvzg
Copy link
Copy Markdown
Member

@bruvzg bruvzg commented Dec 11, 2025

Fixes #113872

Instead of checking only direct parent, look deeper for the first encountered grandparent CanvasItem when selecting inherited texture filter/repeat, so it will over for subwindows and nodes inside non-CanvasItem parents.

@bruvzg bruvzg added this to the 4.6 milestone Dec 11, 2025
@scgm0
Copy link
Copy Markdown
Contributor

scgm0 commented Dec 11, 2025

Will this invalidate the texture filter/repeat settings on the subwindows?

@bruvzg
Copy link
Copy Markdown
Member Author

bruvzg commented Dec 11, 2025

Will this invalidate the texture filter/repeat settings on the subwindows?

This might indeed be wrong, I have not noticed Viewport already have its own texture filter settings.

@scgm0
Copy link
Copy Markdown
Contributor

scgm0 commented Dec 11, 2025

Perhaps inheritance functionality should also be added for settings such as texture filters on the Viewport.

@bruvzg
Copy link
Copy Markdown
Member Author

bruvzg commented Mar 6, 2026

Superseded by #117139

@bruvzg bruvzg closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PopupMenu doesn't inherit Texture Filter from project or parents

3 participants