Skip over non-CanvasItem parents when selecting texture filter properties.#113883
Closed
bruvzg wants to merge 1 commit into
Closed
Skip over non-CanvasItem parents when selecting texture filter properties.#113883bruvzg wants to merge 1 commit into
bruvzg wants to merge 1 commit into
Conversation
Contributor
|
Will this invalidate the texture filter/repeat settings on the subwindows? |
Member
Author
This might indeed be wrong, I have not noticed |
Contributor
|
Perhaps inheritance functionality should also be added for settings such as texture filters on the |
Member
Author
|
Superseded by #117139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113872
Instead of checking only direct parent, look deeper for the first encountered grandparent
CanvasItemwhen selecting inherited texture filter/repeat, so it will over for subwindows and nodes inside non-CanvasItem parents.