Optimize AnimationTree#113444
Closed
TokageItLab wants to merge 2 commits into
Closed
Conversation
TokageItLab
force-pushed
the
opt-tree
branch
3 times, most recently
from
35d9546 to
63918f7
Compare
Member
|
Master was updated @TokageItLab if we're trying to get this into 4.6. |
Member
Author
|
We may need to test benchmark measurements for #113448 first. |
co-authored-by: Ryan-000 <73148864+Ryan-000@users.noreply.github.com>
TokageItLab
force-pushed
the
opt-tree
branch
from
4fa4883 to
bf3b358
Compare
co-authored-by: Ryan-000 <73148864+Ryan-000@users.noreply.github.com>
TokageItLab
force-pushed
the
opt-tree
branch
from
bf3b358 to
a7a912d
Compare
TokageItLab
commented
Dec 31, 2025
Comment on lines
+823
to
+825
| Pair<Variant, bool> *param = property_map.getptr(key); | ||
| if (!param) { | ||
| param = &property_map.insert(key, Pair<Variant, bool>())->value; |
Member
Author
There was a problem hiding this comment.
@Ryan-000 Do you have any idea to remove get_value_ref_or_add_default() like #113448 (comment) ?
In my PR, this migration is not properly completed, so the AnimationTree is not displayed.
Ryan-000
reviewed
Jan 2, 2026
Comment on lines
+827
to
+828
| param->first = p_node->get_parameter_default_value(pname); | ||
| param->second = p_node->is_parameter_read_only(pname); |
Contributor
There was a problem hiding this comment.
This should only be run when added for the first time, so it needs to be moved inside the if (!param) { block.
Member
|
Superseded by #117277. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
co-authored-by: @Ryan-000