Skip to content

Exclude unsupported pixel formats from Linux camera feed #113358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shiena wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −0
Open

Exclude unsupported pixel formats from Linux camera feed #113358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions modules/camera/camera_feed_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,21 @@ void CameraFeedLinux::update_buffer_thread_func(void *p_func) {
}
}

bool CameraFeedLinux::is_format_supported(uint32_t p_pixel_format) {
switch (p_pixel_format) {
case V4L2_PIX_FMT_MJPEG:
case V4L2_PIX_FMT_JPEG:
case V4L2_PIX_FMT_YUYV:
case V4L2_PIX_FMT_YYUV:
case V4L2_PIX_FMT_YVYU:
case V4L2_PIX_FMT_UYVY:
case V4L2_PIX_FMT_VYUY:
return true;
default:
return false;
}
}

void CameraFeedLinux::_update_buffer() {
while (!exit_flag.is_set()) {
_read_frame();
Expand Down Expand Up @@ -105,6 +120,10 @@ void CameraFeedLinux::_query_device(const String &p_device_name) {
}

void CameraFeedLinux::_add_format(v4l2_fmtdesc p_description, v4l2_frmsize_discrete p_size, int p_frame_numerator, int p_frame_denominator) {
if (!CameraFeedLinux::is_format_supported(p_description.pixelformat)) {
return;
}

FeedFormat feed_format;
feed_format.width = p_size.width;
feed_format.height = p_size.height;
Expand Down
1 change: 1 addition & 0 deletions modules/camera/camera_feed_linux.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class CameraFeedLinux : public CameraFeed {
BufferDecoder *buffer_decoder = nullptr;

static void update_buffer_thread_func(void *p_func);
static bool is_format_supported(uint32_t p_pixel_format);

void _update_buffer();
void _query_device(const String &p_device_name);
Expand Down
Loading