Fix fake UID cache entries #112936
Open
Fix fake UID cache entries #112936
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `ResourceUID::remove_id()` is called, the UID cache is removed from memory, but not from the cache file. These entries will be loaded from the cache file into memory the next time the editor is launched, and cannot be removed. When `ResourceUID::update_cache()` is called, if the file has only been moved previously, it appends the new entries to the end of the cache file. If the file has been moved repeatedly, this will result in a large number of duplicate entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ResourceUID::remove_id()is called, the UID cache is removed from memory, but not from the cache file. These entries will be loaded from the cache file into memory the next time the editor is launched, and cannot be removed.When
ResourceUID::update_cache()is called, if the file has only been moved previously, it appends the new entries to the end of the cache file. If the file has been moved repeatedly, this will result in a large number of duplicate entries.Although we can rely on
ResourceUID::clear()to clean up, butResourceUID::clear()is only called when the editor is launched (during the first scan).Upon closer examination, retaining these legacy UIDs seems to make sense. For example, if you need to switch between different Git branches. And
.godotis generally not tracked by Git.At its root, the problem is mainly due to insufficient precision in the timestamps of the file's modification time.