Add missing mipmaps to RB_TEX_BACK_COLOR
#112932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:rendering
topic:3d
cherrypick:4.5
skorpnok
force-pushed
the
missing_screen_texture_mipmaps
branch
from
618031f to
94f433c
Compare
Contributor
Author
|
fixed code style. |
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
akien-mga
changed the title
RB_TEX_BACK_COLOR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112885
When FSR2 is enabled it hits the code path where the blur texture is not reused, and
RB_TEX_BACK_COLORis created and used instead. It was created without mipmaps causingtextureLod()to not work as expected onscreen_texture.This has a small vram penalty. If the penalty for projects not using any blur is too big then introducing a flag like
scene_state.used_screen_texture_mipmappedto decide whether mipmaps are needed might be worthwhile.