Remove redundant vertices from HeightMapShape3D debug mesh
#112921
+47
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeightMapShape3D::get_debug_arraymesh_faceswas creating 4 vertices (position+color) per grid quad instead of a single vertex per grid point. Made it not generate duplicated vertices. The mesh layout/topology remains unchanged (hence index count is the same before/after).map_width⨯map_depthvertex count
vertex count
W⨯D(W - 1) * (D - 1) * 4W * DFixed
HeightMapShape3D::get_debug_arraymesh_faceserroring whenmap_width == 1ormap_depth == 1(which are allowed by relevant setters).Made
HeightMapShape3D::get_debug_mesh_lines()not use.write()while generating line points.