[TextServer] Fix range for zero-width glyphs extra spacing.#111964
Merged
Conversation
bruvzg
added
bug
regression
topic:gui
cherrypick:4.5
Contributor
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
ArchercatNEO
added a commit
to ArchercatNEO/godot
that referenced
this pull request
Mar 21, 2026
Fixes godotengine#117676 PR godotengine#111964 made a Ref<ColorManagementProfile> which we intentionally leaked across a client-server barrier owned, which caused a use-after-free. Manually adding reference/unreference calls keeps the ptr valid without memory leaks.
Sysex89
pushed a commit
to Sysex89/godot
that referenced
this pull request
Mar 26, 2026
Fixes godotengine#117676 PR godotengine#111964 made a Ref<ColorManagementProfile> which we intentionally leaked across a client-server barrier owned, which caused a use-after-free. Manually adding reference/unreference calls keeps the ptr valid without memory leaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wrong range used #110317
Fixes #110301 for single character text.