Fix weak and strong joypad vibration being swapped#111191
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 3, 2025
Merged
Fix weak and strong joypad vibration being swapped#111191Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
bruvzg
added
bug
topic:input
cherrypick:4.5
bruvzg
approved these changes
Oct 3, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
Tested it with DualSense controller, and subjectively it feels correct:
- low frequency - strong (left motor)
- high frequency - weak (right motor)
Contributor
|
Thanks! |
Contributor
|
Cherry-picked to 4.5 |
Repiteo
removed
the
cherrypick:4.5
kilian-diener
added a commit
to kilian-diener/godot
that referenced
this pull request
Oct 15, 2025
…g swapped Co-authored-by: Nintorch <92302738+Nintorch@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110811
It happened because I confused the terminology, I initially thought that weak vibration means low frequency rumble, and strong vibration means high frequency rumble, my bad :D