Clean up numeric EditorProperty setup() methods#108065
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 14, 2025
Merged
Clean up numeric EditorProperty setup() methods#108065Repiteo merged 1 commit intogodotengine:masterfrom
setup() methods#108065Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
79be1dc to
11e31fd
Compare
setup() methodssetup() methods
11e31fd to
821ab0b
Compare
821ab0b to
236c7e8
Compare
aaronfranke
reviewed
Sep 25, 2025
236c7e8 to
fab6bbe
Compare
KoBeWi
reviewed
Oct 8, 2025
Member
|
This could wait for #100749 property->setup(EditorPropertyRangeHint{ .min = range.x, .max = range.y, .or_greater = false, or_less = false });etc. |
KoBeWi
reviewed
Oct 8, 2025
KoBeWi
approved these changes
Oct 8, 2025
Member
KoBeWi
left a comment
There was a problem hiding this comment.
Looks good.
The new syntax I mentioned in #108065 (comment) could be applied later, the struct doesn't look directly created that much.
fab6bbe to
7998b5e
Compare
Contributor
Author
|
Updated the function signatures as suggested by KoBeWi |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the numeric EditorProperty
setup()methods are somewhat brittle. When these properties are created, they are first bundled into a struct, which is then destructed in the method call. This PR changes the signature of the numericsetup()calls to use the struct directly. This has several benefits:setup()calls have many seemingly arbitrary numbers and booleans that are hard to understand without looking at theeditor_properties.hfile. This change makes it clear within the file what the parameters that the code is changing.Note: In making this change I found multiple invalid calls to
setup(), most looking like:setup(-1, 99999, true);where there is a boolean in the third argument (which is defined asdouble p_step). I'm not sure what the intention was originally, but making this change will prevent future invalid calls and help catch other invalid calls before they are propagated.