Skip to content

[Web] Avoid extra copy when encoding string in WebSocket _onmessage #105571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Repiteo merged 1 commit into from
Jun 2, 2025
Merged

[Web] Avoid extra copy when encoding string in WebSocket _onmessage #105571

Repiteo merged 1 commit into from
Jun 2, 2025

Conversation

@marcosc90
Copy link
Contributor

@marcosc90 marcosc90 commented Apr 19, 2025 •
edited
Loading

This PR avoids an extra copy when handling string messages in the WebSocket _onmessage handler.
TextEncoder.encode() already returns a Uint8Array

@marcosc90 marcosc90 requested a review from a team as a code owner April 19, 2025 15:50
@AThousandShips AThousandShips added this to the 4.x milestone Apr 19, 2025
@marcosc90 marcosc90 changed the title Web: Avoid extra copy when encoding string in WebSocket _onmessage [Web] Avoid extra copy when encoding string in WebSocket _onmessage Apr 21, 2025
Faless
Faless approved these changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spot 🥇 ! LGTM.

@akien-mga akien-mga modified the milestones: 4.x, 4.5 Jun 2, 2025
@Repiteo Repiteo merged commit 760b352 into godotengine:master Jun 2, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 2, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Faless Faless Faless approved these changes

Assignees

No one assigned

Labels

enhancement performance platform:web topic:network

Projects

None yet

Milestone

4.5

Development

Successfully merging this pull request may close these issues.

6 participants

@marcosc90 @Repiteo @Faless @akien-mga @clayjohn @AThousandShips