RenderingDevice: Pass mipmap count to texture_create_from_extension()

[kroketio]

Godot hardcodes mipmap count in texture_create_from_extension()

godot/servers/rendering/rendering_device.cpp

Line 1195 in 2d3bdca

texture.mipmaps = 1;

My texture is shown in 3D, and with Godot ignoring mips, it looks worse than needed. For that reason I introduced parameter p_mipmaps to support specifying mipmap count.

Changes the function signature, however I suspect not many are using it, apart from the internal openxr module.

[kroketio]

Alternatively, to maintain compatibility., parameter p_mipmaps can be given a default of 1.

[clayjohn]

You will need to add compatibility bindings since this breaks compatibility. How to do so is described here https://docs.godotengine.org/en/latest/contributing/development/handling_compatibility_breakages.html

[kroketio]

Thanks, PR updated.

[Mickeon]

Given the breaking nature of this, this could be further discussed by opening a proposal. Although, I'm not hearing objections, and I do understand that talks about RenderingDevice will probably fly over most people's heads

[Mickeon]

Description is okay. Even without this PR it's very, very difficult to localize, but it's good to mention the new parameter at least.

[kroketio]

The change looks scary, but this function in general was only exclusively used by the internal openxr module up until last September when I exposed it for use from a gdextension #96860, as up till then, that was not possible. This is why I suspect I am the only user. Regardless of the number of users, anyone who imports an external texture would also like to specify the mipmap count I believe, especially if that texture is to be shown in 3D.

[dsnopek]

This looks OK to me!

As far as compatibility, I think this is fine with the compatibility methods for GDExtension. Given that you need to pass in a native handle, this API can't really be used from anything except GDExtension, so we shouldn't need to worry about GDScript breakage.

[kroketio]

Sorry, missed the review(s) by @AThousandShips
PR updated.

[Repiteo]

Thanks!